Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for apx #306

Closed
Zahrun opened this issue Jan 8, 2023 · 8 comments
Closed

Support for apx #306

Zahrun opened this issue Jan 8, 2023 · 8 comments

Comments

@Zahrun
Copy link
Contributor

Zahrun commented Jan 8, 2023

I want to suggest a new step

Which tool is this about? Where is its repository?

https://github.com/Vanilla-OS/apx

Which operating systems are supported by this tool?

Linux

What should Topgrade do to figure out if the tool needs to be invoked?

apx command exists

Which exact commands should Topgrade run?

apx update
apx upgrade

@jim3692
Copy link

jim3692 commented Jan 9, 2023

It's more complicated than that. You also need to specify which distro you want to update (ex apx --dnf update ; apx --dnf upgrade), or which named container you want to update (ex apx --dnf --name fedora_1 update ; apx --dnf --name fedora_1 upgrade)

@Zahrun
Copy link
Contributor Author

Zahrun commented Jan 10, 2023

Actually the distrobox step might already do the work if it functions well

@jim3692
Copy link

jim3692 commented Jan 10, 2023

Which distrobox step? Is there already a better way to do that?

@Zahrun
Copy link
Contributor Author

Zahrun commented Jan 10, 2023

See https://github.com/topgrade-rs/topgrade/blob/master/src/steps/os/linux.rs#L638
It runs /usr/bin/distrobox upgrade --all
Will this upgrade apx installed packages automatically?

@jim3692
Copy link

jim3692 commented Jan 10, 2023

I was not aware of that. Thank you for pointing it. However I spotted a small issue that should be solved on distobox's side. It looks like they do not support yay, which is used for AUR packages.

https://github.com/89luca89/distrobox/blob/0e24aae53ae6e2fd6901db3556de9e6b261e7a6f/distrobox-init#L458

[EDIT 1] There is this PR about yay and paru which was rejected 89luca89/distrobox#569

@s34m
Copy link
Member

s34m commented Jan 17, 2023

Can I close this issue? @jim3692 @Zahrun

@jim3692
Copy link

jim3692 commented Jan 18, 2023

@DottoDev we can probably close it for now, and we will open it again when the work in apx side is complete, or I will try to make a PR for apx support

@s34m
Copy link
Member

s34m commented Jan 18, 2023

👍

@s34m s34m closed this as completed Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants