Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tracing #174

Merged
merged 4 commits into from Nov 16, 2022
Merged

Use tracing #174

merged 4 commits into from Nov 16, 2022

Conversation

9999years
Copy link
Contributor

tracing is the standard logging library, used by rustc. Let's use it. In a future PR we can start leaning on tracing's tools, annotating functions, and so on.

Might tweak the output format a bit more.

`tracing` is the standard logging library, used by rustc. Let's use it.
In a future PR we can start leaning on `tracing`'s tools, annotating
functions, and so on.
src/config.rs Outdated Show resolved Hide resolved
@s34m
Copy link
Member

s34m commented Nov 13, 2022

I'll review it.

@s34m s34m self-assigned this Nov 14, 2022
Copy link

@Larandar Larandar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some thoughts :)

src/config.rs Outdated Show resolved Hide resolved
src/terminal.rs Show resolved Hide resolved
@s34m s34m merged commit 89a5825 into topgrade-rs:dev Nov 16, 2022
@9999years 9999years deleted the tracing branch November 16, 2022 23:16
s34m pushed a commit that referenced this pull request Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants