Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add garuda-update #227

Merged
merged 6 commits into from Nov 26, 2022
Merged

Add garuda-update #227

merged 6 commits into from Nov 26, 2022

Conversation

jstelzer
Copy link
Contributor

@jstelzer jstelzer commented Nov 25, 2022

if garuda-update is in our path use that instead of directly calling pacman/paru/powerpill. There's more stuff the update script does that you're just asking for problems if you upgrade partially.

Standards checklist:

  • The PR title is descriptive.
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself
    • I also tested that Topgrade skips the step where needed

I created a feature request here:
#226

if garuda-update is in our path use that instead of directly calling
pacman/paru/powerpill. There's more stuff the update script does that
you're just asking for problems if you upgrade partially.
@s34m s34m closed this Nov 25, 2022
@s34m s34m reopened this Nov 25, 2022
Copy link
Member

@s34m s34m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format it first before this PR can be merged.

@jstelzer
Copy link
Contributor Author

Sorry if it's dense, but what do you want WRT format? Just rustfmt? Other than that I merged in dev (i based the original patch off of master due to not knowing your workflow).

1 similar comment
@jstelzer
Copy link
Contributor Author

Sorry if it's dense, but what do you want WRT format? Just rustfmt? Other than that I merged in dev (i based the original patch off of master due to not knowing your workflow).

@s34m
Copy link
Member

s34m commented Nov 26, 2022

Jup, was just about rust Mt and clippy warnings

@s34m s34m merged commit 37b900c into topgrade-rs:dev Nov 26, 2022
@jstelzer
Copy link
Contributor Author

danke schoen

@jstelzer jstelzer deleted the add-garuda-update-support branch November 27, 2022 13:34
@guihkx guihkx mentioned this pull request Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants