refactor: make all step functions take &ExectutionContext #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveLauC
force-pushed
the
ExecutionContext
branch
from
3bbbd2b
to
43111c3
Compare
s34m
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standards checklist:
cargo build)cargo fmt)cargo clippy)cargo test)If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.
Closes #223
The step functions take all sorts of parameters, when I first contributed to
topgrade, this really confused me and is obviously unfriendly to the new contributors, we should make them all consistent, and add some doc on how to add new steps inCONTRIBUTING.md