Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Vanilla Linux #447

Merged
merged 1 commit into from
May 29, 2023
Merged

feat: support Vanilla Linux #447

merged 1 commit into from
May 29, 2023

Conversation

SteveLauC
Copy link
Member

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself
    • I also tested that Topgrade skips the step where needed

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.


Ref:

They do have a rendered online manual page, but it is kinda outdated.

@SteveLauC
Copy link
Member Author

Don’t merge this for now, let me find some folk from the Vanilla Community to get it reviewed first

@s34m s34m merged commit f6e8af1 into topgrade-rs:master May 29, 2023
7 checks passed
@SteveLauC
Copy link
Member Author

Emmm, alright then, I honestly think this patch should work as I have tested the following commands:

$ apx update --all -y
$ apx upgrade --all -y

in a live boot.

@SteveLauC SteveLauC deleted the vanilla branch May 29, 2023 11:50
@s34m
Copy link
Member

s34m commented May 29, 2023

Don’t merge this for now, let me find some folk from the Vanilla Community to get it reviewed first

Was on my phone and your comment didn't show up xD

Should I revert the merge?

@SteveLauC
Copy link
Member Author

Should I revert the merge?

Let's leave it merged, I think this is generally fine.

Don’t merge this for now, let me find some folk from the Vanilla Community to get it reviewed first

And probably there won't be any folk from the Vanilla community that will give it a review, sigh. I will try to set up an installed Vanilla OS in a VM tomorrow, and give this patch a full test.
Vanilla OS will roughly take an hour to install, and I have no idea if it is stuck or still installing during the installation, I hope I can get it successfully installed tomorrow...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants