Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run AM without sudo #454

Merged
merged 1 commit into from
May 31, 2023
Merged

fix: run AM without sudo #454

merged 1 commit into from
May 31, 2023

Conversation

SteveLauC
Copy link
Member

@SteveLauC SteveLauC commented May 31, 2023

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself
    • I also tested that Topgrade skips the step where needed

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.


  1. AM should not be executed with sudo
  2. am -u requires the user to answer a prompt, am -U does not. So when assume_yes = true is set in the configuration, we use am -U, otherwise, use am -u.

Closes #453

@SteveLauC SteveLauC changed the title fix: run AM with sudo fix: run AM without sudo May 31, 2023
@s34m s34m merged commit 3f5eedb into topgrade-rs:master May 31, 2023
7 checks passed
@SteveLauC SteveLauC deleted the am branch May 31, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AM don't requires "sudo" to update
2 participants