Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test for config file creation and default config file parsing #459

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

SteveLauC
Copy link
Member

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • The code passes tests (cargo test)

Closes #451

What does this PR do

  1. Add test for:
    1. check the default configuration in config.example.toml is valid in config.rs (unit test)
    2. topgrade will create a default configuration file in ~/.config.topgrade.toml (CI)

Some questions

  1. It seems that .github/workflow/test.yaml is not being run in the CI, only check-and-lint.yaml is.
  2. Unit tests are not covered in the CI for the reason stated in 1

@s34m
Copy link
Member

s34m commented Jun 5, 2023

.github/workflow/test.yaml isn't activated right now because the only test in it was the code coverage test, which is useless rn, till now

@s34m s34m merged commit 06cb88a into topgrade-rs:master Jun 23, 2023
1 check passed
@SteveLauC SteveLauC deleted the test_config branch June 23, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI test for the configuration file
2 participants