Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generic): add alternate binary name for spicetify #486

Merged
merged 1 commit into from
Jul 14, 2023
Merged

fix(generic): add alternate binary name for spicetify #486

merged 1 commit into from
Jul 14, 2023

Conversation

msfjarvis
Copy link
Contributor

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself
    • I also tested that Topgrade skips the step where needed

NixOS packages spicetify as spicetify-cli which means the step is skipped on NixOS machines even if spicetify is actually present.

@SteveLauC
Copy link
Member

If this binary name is ONLY used on NixOS, it would be great to document it in the comment:)

@msfjarvis
Copy link
Contributor Author

If this binary name is ONLY used on NixOS, it would be great to document it in the comment:)

Added a comment.

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #486 (f77e2c6) into master (9cd155f) will decrease coverage by 0.15%.
The diff coverage is 2.12%.

@@            Coverage Diff            @@
##           master    #486      +/-   ##
=========================================
- Coverage    3.50%   3.36%   -0.15%     
=========================================
  Files          27      31       +4     
  Lines        3141    4194    +1053     
=========================================
+ Hits          110     141      +31     
- Misses       3031    4053    +1022     
Impacted Files Coverage Δ
src/command.rs 0.00% <0.00%> (ø)
src/ctrlc/interrupted.rs 0.00% <ø> (ø)
src/error.rs 0.00% <0.00%> (ø)
src/execution_context.rs 0.00% <0.00%> (ø)
src/executor.rs 0.00% <0.00%> (ø)
src/main.rs 0.36% <0.00%> (-0.06%) ⬇️
src/report.rs 0.00% <0.00%> (ø)
src/runner.rs 0.00% <0.00%> (ø)
src/steps/containers.rs 0.00% <0.00%> (ø)
src/steps/emacs.rs 0.00% <0.00%> (ø)
... and 20 more

@s34m s34m merged commit afd95e3 into topgrade-rs:master Jul 14, 2023
8 of 10 checks passed
@msfjarvis msfjarvis deleted the hs/adjust-spicetify branch July 14, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants