Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: separate code-coverage and test-config-creation #488

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

SteveLauC
Copy link
Member

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md

What does this PR do

CI code-coverage is kinda useless? It makes CI fail for almost all the PRs, this PR separates code-coverage and test-config-creation so that we can disable code-coverage.

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #488 (6b6e31f) into master (9cd155f) will decrease coverage by 0.15%.
The diff coverage is 2.12%.

@@            Coverage Diff            @@
##           master    #488      +/-   ##
=========================================
- Coverage    3.50%   3.36%   -0.15%     
=========================================
  Files          27      31       +4     
  Lines        3141    4194    +1053     
=========================================
+ Hits          110     141      +31     
- Misses       3031    4053    +1022     
Impacted Files Coverage Δ
src/command.rs 0.00% <0.00%> (ø)
src/ctrlc/interrupted.rs 0.00% <ø> (ø)
src/error.rs 0.00% <0.00%> (ø)
src/execution_context.rs 0.00% <0.00%> (ø)
src/executor.rs 0.00% <0.00%> (ø)
src/main.rs 0.36% <0.00%> (-0.06%) ⬇️
src/report.rs 0.00% <0.00%> (ø)
src/runner.rs 0.00% <0.00%> (ø)
src/steps/containers.rs 0.00% <0.00%> (ø)
src/steps/emacs.rs 0.00% <0.00%> (ø)
... and 20 more

@s34m s34m merged commit 53a8683 into topgrade-rs:master Jul 14, 2023
9 of 11 checks passed
@SteveLauC SteveLauC deleted the ci branch July 14, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants