Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

steps/toolbx: Don't self-update and don't send notifications #503

Merged

Conversation

har7an
Copy link
Contributor

@har7an har7an commented Jul 16, 2023

This PR refines the toolbx update step, which is currently implemented as entering into the target toolbx container and then executing the running topgrade executable from there. The following changes to topgrades behavior in the toolbx container are made:

  • Don't perform anther topgrade self-update (because the "outer" topgrade will have done that before)
  • Don't show "update finished" notifications (because this is confusing and leads users to believe that topgrade finished rather quickly)

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself
    • I also tested that Topgrade skips the step where needed

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

after finishing execution in the toolbx step, and don't perform another
self-update (because the application will already have done that).
@SteveLauC SteveLauC merged commit 3735d5c into topgrade-rs:master Jul 17, 2023
8 checks passed
@SteveLauC
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants