Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix Linux and DragonFlyBSD yes option #513

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

SteveLauC
Copy link
Member

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself
    • I also tested that Topgrade skips the step where needed

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.


What does this PR do
  1. Change the yes option from

    .arg(if ctx.config().yes(Step::System) { "-y" } else { "" })

    to

    if ctx.config().yes(Step::System) {
        cmd.arg("-y");
    }

@SteveLauC
Copy link
Member Author

Here is a build for x86_64-unknown-linux-musl, would you like to give it a test? @LordChaos73

Closes #512

@SteveLauC SteveLauC linked an issue Jul 24, 2023 that may be closed by this pull request
@signed-log
Copy link
Contributor

Sorry for introducing that (seems like I didn't test assume_yes=false), I will be able to test on my side too today

Copy link
Contributor

@signed-log signed-log left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can repro the original bug, this solves it with assume_yes=false

No regressions on assume_yes=true

@SteveLauC SteveLauC merged commit 1ec0ac5 into topgrade-rs:master Jul 25, 2023
8 checks passed
@SteveLauC SteveLauC deleted the fix-yes-opt branch July 25, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Topgrade 12.0.1 fails on openSUSE Tumbleweed
2 participants