Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helix fetches grammar as a regular user #698

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

InnocentZero
Copy link
Contributor

@InnocentZero InnocentZero commented Feb 17, 2024

Prior to this commit, helix grammars were fetched with sudo privileges. There is no need for this, and it was also a bug. Closes #697 .

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself

For new steps

  • Optional: Topgrade skips this step where needed
  • Optional: The --dry-run option works with this step
  • Optional: The --yes option works with this step if it is supported by
    the underlying command

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

@SteveLauC
Copy link
Member

SteveLauC commented Feb 22, 2024

Is this helix tool the helix editor? On my host, the binary is called hx rather than helix:

$ hx --version
helix 23.10 (f6021dd0)

@InnocentZero
Copy link
Contributor Author

Is this helix tool the helix editor? On my host, the binary is called hx rather than helix:

$ hx --version
helix 23.10 (f6021dd0)

Yes. In my system it's still helix and the alias hx is not available.

Prior to this commit, helix grammars were fetched with sudo privileges.
There is no need for this, and it was also a bug.

Signed-off-by: innocentzero <isfarulhaque@proton.me>
@SteveLauC SteveLauC merged commit 12b0fa5 into topgrade-rs:main Feb 22, 2024
9 checks passed
@InnocentZero
Copy link
Contributor Author

@SteveLauC has this not been pushed to crates.io? I still see that helix is trying to fetch grammars using sudo.

@SteveLauC
Copy link
Member

@SteveLauC has this not been pushed to crates.io?

No, I haven't released this patch yet. Well, I should release it, will try to do it, maybe this weekend.

@SteveLauC
Copy link
Member

Hi, v15.0.0 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Topgrade installs helix grammars using sudo, not as user.
2 participants