Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: allow unused ExecutorChild #829

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Conversation

SteveLauC
Copy link
Member

What does this PR do

Clear the following clippy warning:

error: field `0` is never read
   --> src/executor.rs:230:9
    |
[230](https://github.com/topgrade-rs/topgrade/actions/runs/9573017990/job/26393598748?pr=827#step:7:231) |     Wet(Child),
    |     --- ^^^^^
    |     |
    |     field in this variant
    |
    = note: `-D dead-code` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(dead_code)]`
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
    |
230 |     Wet(()),
    |         ~~

It is indeed unused, but we should not remove it.

Standards checklist

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • Optional: I have tested the code myself

For new steps

  • Optional: Topgrade skips this step where needed
  • Optional: The --dry-run option works with this step
  • Optional: The --yes option works with this step if it is supported by
    the underlying command

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

@SteveLauC SteveLauC merged commit d8406a8 into topgrade-rs:main Jun 19, 2024
11 checks passed
@SteveLauC SteveLauC deleted the clippy branch June 19, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant