Skip to content
This repository has been archived by the owner on Nov 3, 2022. It is now read-only.

Commitwatch sometimes picks up merged PRs' commit messages and tries to format them #18

Open
mcataford opened this issue Mar 5, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@mcataford
Copy link
Member

In some cases, CW will inexplicable pick up on commit messages from commits that are already merged in master. Since the commit message format isn't enforced beyond branch pushes, this breaks the formatting function as one would expect.

image

This problem is intermittent and couldn't be reliably reproduced, but it happens every once and again. This hints at a yet-unexplored gap in how CW builds the list of messages it'll lint.

@mcataford mcataford added the bug Something isn't working label Mar 5, 2020
@msrose
Copy link
Contributor

msrose commented Mar 12, 2020

I don't think this has to do with picking up commits from the main branch, based on the error message. It seems like certain commits will cause the format function to fail, but it can happen to any commit it seems. Commit watch also doesn't control which commits get linted as far as I understand, but I'm not entirely familiar with it.

@msrose
Copy link
Contributor

msrose commented Mar 13, 2020

I've discovered the immediate problem and will put up a fix soon

@msrose
Copy link
Contributor

msrose commented Mar 13, 2020

Addressed the immediate error in #19 but will leave this open because there will likely be other errors related to linting incorrect messages

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants