Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: explicitly callout required config and env #39

Merged
merged 3 commits into from
Jan 15, 2020
Merged

refactor: explicitly callout required config and env #39

merged 3 commits into from
Jan 15, 2020

Conversation

iamogbz
Copy link
Contributor

@iamogbz iamogbz commented Jan 15, 2020

Description

  • Create constants file to house common options
  • Rename private verifyConfig to verifyOptions

Checklist

  • This PR has updated documentation
  • This PR has sufficient testing

DevQA

  • Covered by tests and e2es

Comments

  • No feature change, purely refactor

@iamogbz iamogbz requested a review from dbasilio January 15, 2020 11:44
dbasilio
dbasilio reviewed Jan 15, 2020
View reviewed changes
src/utils.js Outdated Show resolved Hide resolved
@iamogbz iamogbz requested a review from dbasilio January 15, 2020 15:20
dbasilio
dbasilio approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@dbasilio dbasilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iamogbz iamogbz merged commit 41310a6 into master Jan 15, 2020
@iamogbz iamogbz deleted the refactor-patch-1 branch January 15, 2020 15:31
@iamogbz
Copy link
Contributor Author

iamogbz commented Jan 15, 2020

🎉 This PR is included in version 0.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dependabot-preview dependabot-preview bot mentioned this pull request Jun 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbasilio dbasilio dbasilio approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iamogbz @dbasilio