fix: import 'sign-addon' correctly

[iorate]

Description

Checklist

• This PR has updated documentation
• This PR has sufficient testing

DevQA

Comments

I unsuccessfully tried to release my add-on using v0.2.4 due to the following errors:

[10:43:23 AM] [semantic-release] › ℹ  Start step "publish" of plugin "semantic-release-firefox-add-on"
Building web extension from dist/firefox/production
[10:43:23 AM] [semantic-release] › ✖  Failed step "publish" of plugin "semantic-release-firefox-add-on"
[10:43:23 AM] [semantic-release] › ✖  An error occurred while running semantic-release: TypeError: defaultAddonSigner is not a function
    at signAddon (/home/runner/work/uBlacklist/uBlacklist/node_modules/semantic-release-firefox-add-on/src/publish.js:34:30)
    at /home/runner/work/uBlacklist/uBlacklist/node_modules/web-ext/dist/web-ext.js:1:66145
    at publish (/home/runner/work/uBlacklist/uBlacklist/node_modules/semantic-release-firefox-add-on/src/publish.js:46:33)
    at validator (/home/runner/work/uBlacklist/uBlacklist/node_modules/semantic-release/lib/plugins/normalize.js:34:24)
    at /home/runner/work/uBlacklist/uBlacklist/node_modules/semantic-release/lib/plugins/pipeline.js:37:34
    at async Promise.all (index 0)
    at next (/home/runner/work/uBlacklist/uBlacklist/node_modules/p-reduce/index.js:16:18) {
  pluginName: 'semantic-release-firefox-add-on'
}
TypeError: defaultAddonSigner is not a function
    at signAddon (/home/runner/work/uBlacklist/uBlacklist/node_modules/semantic-release-firefox-add-on/src/publish.js:34:30)
    at /home/runner/work/uBlacklist/uBlacklist/node_modules/web-ext/dist/web-ext.js:1:66145
    at publish (/home/runner/work/uBlacklist/uBlacklist/node_modules/semantic-release-firefox-add-on/src/publish.js:46:33)
    at validator (/home/runner/work/uBlacklist/uBlacklist/node_modules/semantic-release/lib/plugins/normalize.js:34:24)
    at /home/runner/work/uBlacklist/uBlacklist/node_modules/semantic-release/lib/plugins/pipeline.js:37:34
    at async Promise.all (index 0)
    at next (/home/runner/work/uBlacklist/uBlacklist/node_modules/p-reduce/index.js:16:18) {
  pluginName: 'semantic-release-firefox-add-on'
}
##[error]Process completed with exit code 1.

sign-addon should be imported as const defaultAddonSigner = require('sign-addon').default.

[iamogbz]

LGTM

• Do you have an idea of a good way to test for this? Since the e2e didn't catch it because semantic-release dryRun does not mock the publish step.

[iamogbz]

🎉 This PR is included in version 0.2.5 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

[iorate]

@iamogbz Thank you!

I'm not familiar with testing and CI, but how about moving the e2e to another git repository and making it publish actually?

1. Move the e2e to another repository.
2. Set up the CI of the e2e to run semantic-release with dryRun: false and actually publish a fake add-on.
   • It should be avoided to publish a fake add-on to AMO. addons-dev.allizom.org seems available instead (ref).
3. In the test of semantic-release-firefox-add-on, push a fake commit to the e2e repository and receive a result of the CI.

[iamogbz]

@iorate thanks for that link, will look into using the fake. Although moving it into another repo wouldn't quite work as we want to run the tests before merging or releasing.