Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: release syrupy v2 #575

Merged
merged 2 commits into from
Apr 10, 2022
Merged

feat: release syrupy v2 #575

merged 2 commits into from
Apr 10, 2022

Conversation

noahnu
Copy link
Collaborator

@noahnu noahnu commented Dec 26, 2021

Syrupy v2

Breaking Changes

Deferred to v3

  • Reclaim much of the API as internal implementation details so it's no longer part of the "public API contract"

BREAKING CHANGE: update to serialization requires regeneration of snapshots

Migration Guide
* `pytest --snapshot-update` to regenerate amber snapshots
@codecov
Copy link

codecov bot commented Feb 20, 2022

Codecov Report

Merging #575 (d46122f) into master (17f0660) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #575      +/-   ##
==========================================
- Coverage   99.01%   99.01%   -0.01%     
==========================================
  Files          20       20              
  Lines        1224     1223       -1     
==========================================
- Hits         1212     1211       -1     
  Misses         12       12              

@noahnu noahnu added this to the v2.0.0 milestone Feb 20, 2022
* refactor: add dataclasses backport for python 3.6

* refactor: SnapshotSession to use a dataclass

* refactor: SnapshotReport to use a dataclass

* refactor: SnapshotLocation to dataclass

* refactor: Data to dataclass

* refactor: SnapshotAssertion to dataclass

* feat: remove attrs dependency
@noahnu noahnu marked this pull request as ready for review April 10, 2022 17:25
@noahnu noahnu merged commit bc8b3a9 into master Apr 10, 2022
tophat-opensource-bot pushed a commit that referenced this pull request Apr 10, 2022
# [2.0.0](v1.7.4...v2.0.0) (2022-04-10)

### Features

* **amber:** change serialization to be py syntax like ([#505](#505)) ([b64b965](b64b965))
* release syrupy v2 ([#575](#575)) ([bc8b3a9](bc8b3a9))

### BREAKING CHANGES

* **amber:** update to serialization requires regeneration of snapshots

Migration Guide
* `pytest --snapshot-update` to regenerate amber snapshots
@tophat-opensource-bot
Copy link
Collaborator

🎉 This PR is included in version 2.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@zevisert
Copy link

I just spent a few minutes upgrading, but by adding "*.ambr": "python" to "files.associations", vscode's languge server (pylance) really starts throwing a fit about all the syntax issues since these aren't meant to be valid python. @noahnu, do you have any suggestions on how to get language highlighting, without linting? A # type: ignore comment works, but that's an edit to the snapshot, and a path I think we generally don't want to go down. I tried "python.linting.ignorePatterns", but it didn't seem to have any effect.

The other idea I had was to set the language to something that parses amber well enough, that I don't have a language server for. Perl, Julia, Ruby, and Coffeescript all work well enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants