Only instantiate colored objects if color is not disabled #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We'll need at least 1 test to catch any regression of this functionality. Otherwise a future refactor might accidentally revert it. Alternatively we can add some comments explaining with a link to the GitHub issue. |
|
I added a test for it, feel free to shift it to a more appropriate location |
tophat-opensource-bot
pushed a commit
that referenced
this pull request
Nov 8, 2022
## [3.0.5](v3.0.4...v3.0.5) (2022-11-08) ### Bug Fixes * only instantiate colored objects if color is not disabled ([#634](#634)) ([7f0fe22](7f0fe22))
|
🎉 This PR is included in version 3.0.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
@all-contributors add @mhwaage for bug |
|
I've put up a pull request to add @mhwaage! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Only call colored functions (that instantiate colored objects under the hood) if colors have been enabled.
Related Issues
coloredissues by disabling colors.Checklist
Additional Comments
Not sure about whether/where to add tests to cover the change in behavior, happy to recieve suggestions.