Merge e18dcdf into 86d7322

tophatter · Mar 8, 2019 · cc42754 · cc42754
2 parents 86d7322 + e18dcdf
commit cc42754
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/lib/facebook_ads/ad_set.rb b/lib/facebook_ads/ad_set.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module FacebookAds
-  # https://developers.facebook.com/docs/marketing-api/reference/ad-account/adsets
+  # https://developers.facebook.com/docs/marketing-api/reference/ad-campaign
   class AdSet < Base
     FIELDS = %w[
       id
@@ -21,6 +21,9 @@ class AdSet < Base
       lifetime_budget
       promoted_object
       targeting
+      attribution_spec
+      start_time
+      end_time
       created_time
       updated_time
     ].freeze

diff --git a/spec/fixtures/cassettes/FacebookAds_AdAccount/_ad_sets/lists_ad_sets.yml b/spec/fixtures/cassettes/FacebookAds_AdAccount/_ad_sets/lists_ad_sets.yml
diff --git a/spec/fixtures/cassettes/FacebookAds_AdCampaign/_create_ad_set/creates_valid_ad_set.yml b/spec/fixtures/cassettes/FacebookAds_AdCampaign/_create_ad_set/creates_valid_ad_set.yml