Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose budget related fields for AdCampaign #29

Merged
merged 3 commits into from
Oct 3, 2018
Merged

Expose budget related fields for AdCampaign #29

merged 3 commits into from
Oct 3, 2018

Conversation

joemanley201
Copy link
Contributor

@joemanley201 joemanley201 commented Oct 3, 2018 •
edited
Loading

  • Expose budget fields for AdCampaign. This is needed if we maintain budget at the ad_campaign level and not ad_set level.
  • Change log entry
  • Publish gem

@coveralls
Copy link

coveralls commented Oct 3, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 76.704% when pulling 8817a17 on ad_campaign_expose_budget into 3b7eca5 on master.

@joemanley201 joemanley201 requested a review from cte October 3, 2018 18:54
@joemanley201 joemanley201 merged commit 7fe9625 into master Oct 3, 2018
@joemanley201 joemanley201 deleted the ad_campaign_expose_budget branch October 3, 2018 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cte cte cte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joemanley201 @coveralls @cte