Skip to content

Commit

Permalink
feat(*) don't execute e2e test on pull-requests
Browse files Browse the repository at this point in the history
Because of security reasons, Travis won't export secure token when executing builds from pull-requests made from forks (not original repo).
This ends up not opening sauce connect tunnel, which fails the build.
This also doesn't export the Jspm registry config (which could lead to fail sometime ...)

Solution: don't run e2e tests on pull requests

* http://docs.travis-ci.com/user/pull-requests/
* #2 (comment)
  • Loading branch information
topheman committed Sep 26, 2015
1 parent 823579f commit 7543fce
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ before_script:
- gulp build
- gulp clean
- gulp build --env test
- npm run forever-start-dist
- '[ "${TRAVIS_PULL_REQUEST}" = "false" ] && npm run forever-start-dist || true'
script:
- npm test
- npm run test-e2e
- '[ "${TRAVIS_PULL_REQUEST}" = "false" ] && npm run test-e2e || true'

0 comments on commit 7543fce

Please sign in to comment.