Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for target_observation_weights #15

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

topipa
Copy link
Owner

@topipa topipa commented Apr 1, 2024

This PR does a few improvements to make the package more generalizable.

  • Move all stan related packages to "Enhances". Currently rstan is in "Suggests", but I don't see why rstan should be treated differently
  • Move the basic functions related to brmsfit objects to function-specific folders just like other stan interfaces. Only functions solely used for brmsfit objects stay in a separate file
  • Adds better support for target_observation_weights to make it easier to do loo calculations.
  • Adds tests for using target_observation_weights with different stan objects.

TODO:

  • Add tests also for cmdstan objects
  • Implement cmdstanfit and stanfit methods so that they also update & return the model object.
  • Make all tests work again
  • Come up with a better way to easily handle expectations computed using constrained parameters with brms, rstan & cmdstanfit without user having to do anything special.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant