Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixel 6 pro, recent android december update breaks root. #5057

Closed
mclarence opened this issue Dec 14, 2021 · 11 comments · Fixed by #5059
Closed

Pixel 6 pro, recent android december update breaks root. #5057

mclarence opened this issue Dec 14, 2021 · 11 comments · Fixed by #5059

Comments

@mclarence
Copy link

Device: Google Pixel 6 Pro 512GB
Android version: Android 12 (SQ1D.211205.016.A1, Dec 2021)
Magisk version name: 5d6d241
Magisk version code: 23015

The recent android december update for google pixel 6 breaks root. Magisk manager does not detect root even after flashing the boot image.

Steps to reproduce:

  1. Coming from the november 2021 patch (was rooted), I downloaded the factory image from Google's website, extracted and modified the flash-all.bat to not wipe the data when flashing. The following line was modified:
...
fastboot -w update image-raven-sq1d.211205.016.a1.zip

to

...
fastboot update --disable-verity --disable-verification image-raven-sq1d.211205.016.a1.zip

As you can see verity and verification was disabled and vbmeta did not need to be flashed. I tried to flash vbmeta again but it made no difference.

  1. After successful flashing, I let the system boot normally.
  2. I then extracted the boot.img file from the factory image zip and patched it with magisk manager.
  3. I rebooted to bootloader and flashed the magisk patched boot image with
    fastboot flash boot --slot=all magisk_patched.....img
  4. I reboot again, the system boots up successfully. I then check magisk manager to see that it has not detected that it has been installed. It simply says Installed N/A, Zygisk No, Ramdisk Yes
  5. I attempted to flash again, but it did not work.

Attached logcat:
logcat.txt

@Hal1ucinogen
Copy link

Pixel 6 also encountered the same problem

@Hondo77
Copy link

Hondo77 commented Dec 14, 2021

Also happens on the Android 12 sq1d.211205.017, Dec. 2021 US carriers version of the Pixel 6 Pro using Magisk Canary 23015 using the same method except without the --slot=all when fastboot flashing the patched boot image.

@yujincheng08
Copy link
Collaborator

Please grab a bugreport after reboot: https://developer.android.com/studio/debug/bug-report

@mclarence
Copy link
Author

Bugreport.zip

@Hondo77
Copy link

Hondo77 commented Dec 14, 2021

Please grab a bugreport after reboot:
bugreport-raven-SQ1D.211205.017-2021-12-13-23-11-52.zip

@yujincheng08
Copy link
Collaborator

I think it's caused by this commit:
https://cs.android.com/android/_/android/platform/system/core/+/e98afa2687eb56184dad8569b929eba04fb93068

Will test and submit a PR.

@yujincheng08
Copy link
Collaborator

Please try #5059

@mclarence
Copy link
Author

Screenshot_20211214-171917
Screenshot_20211214-172009

Appears to be working now!

Thanks!!!

@smemsh
Copy link

smemsh commented Dec 14, 2021

My magisk installation still shows 5d6d2417 (23015) as the latest canary, and MAGISK_VER / MAGISK_VER_CODE in app-debug.apk seem to confirm. Where does one obtain this 65e020f6 (23015) version shown in screenshot above? It requires one to build manually in order to apply December update?

@smemsh
Copy link

smemsh commented Dec 14, 2021

I was able to build current trunk a4faa3f (still says version 23015) using README instructions (had to install "command line tools" rather than "build tools" for sdkmanager --licenses to work), installing via adb install (after uninstalling old one), and root has now been restored in the generated boot.img. Since many will try upgrade after December update, might be a good idea to release a new canary...

@smemsh
Copy link

smemsh commented Dec 15, 2021

23016 canary has been released now which contains this patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants