Copy required files to system for addon.d

[jesec]

/data/adb/magisk is not accessible on devices with encrypted data.

[topjohnwu]

Sorry, but there is no plan to support running addon.d without data access as upgrading through Magisk Manager will not also update addon.d

[jesec]

It can be made to update addon.d. I can implement the changes to make it happen if you want. This is rather an improtant issue for our LineageOS (and our downstream projects) users as we are not going to implement data encryption in Lineage recovery.

An alternative solution is to move Magisk files from /data/adb to /data/unencrypted which is unencrypted in FBE systems and fulfills all the criteria documented in https://github.com/topjohnwu/Magisk/blob/master/docs/details.md#paths-in-data. It is even better. Here is a proof of concept and working implementation: https://github.com/jesec/Magisk/tree/dataunencrypted.

[jesec]

Ping @topjohnwu.

I would like to hear your stance on this.

This remains an issue: #1501, #2686, #3496, #3356

BTW: To be honest, I was offended by the (instant-)close of PR without even evaluating my reply. I don't believe such action is constructive. If changes are required, we can discuss, and I can improve or readjust the PR. It is considerably difficult to track a closed PR.

[mu198]

oh that would be such a wonderful relief, but it's a shame that @topjohnwu closed it right away

[shrihankp]

Bump. Does this still remain an issue, by the way?

[mcgi5sr2]

Bump, imho this should not be closed

[mu198]

it is still an issue, but what is completely ignored here, use instead of Lygisk, is a fork of @programminghoch10 and @Linux4, this fork bypasses the problem.

works great on the gta4xlwifi/beyond1lte official/unofficial LOS 18.1/19.0, both FBE encrypted

[chaoscalm]

Any hope to merge this into main?

https://github.com/programminghoch10/Lygisk

[shrihankp]

@srccrow No. Nope. Nada. Zero.

[mid-kid]

Bumping because this is still an issue. If @topjohnwu is not to fix this, I'd love to have a warning about it during installation at least, and some instructions on how to disable encryption...
This is a very weird issue to google for, with many threads and bug reports misunderstanding the request.

[dtristany]

So just to clarify, this is only an issue if you use LOS official recovery? People on TWRP don't need Lygisk and don't have to do anything after OTA? That is, provided your install method was flashing on TWRP and any future updates to magisk also need to be flashed in TWRP recovery and not in the app, to make sure addon.d script is installed and kept updated? Sorry I just couldn't find any info on your official docs on how to intall and update Magysk for A-only devices with LOS and TWRP (I'm confused here re. TWRP flash from internal storage vs sideloading in TWRP, first one doesn't require computer while obviously adb sideload does - which one is recommended for Magysk)

[chaoscalm]

So just to clarify, this is only an issue if you use LOS official recovery? People on TWRP don't need Lygisk and don't have to do anything after OTA? That is, provided your install method was flashing on TWRP and any future updates to magisk also need to be flashed in TWRP recovery and not in the app, to make sure addon.d script is installed and kept updated? Sorry I just couldn't find any info on your official docs on how to intall and update Magysk for A-only devices with LOS and TWRP (I'm confused here re. TWRP flash from internal storage vs sideloading in TWRP, first one doesn't require computer while obviously adb sideload does - which one is recommended for Magysk)

a) TWRP has no more support with LOS, use LineageOS recovery.

b) > Sorry I just couldn't find any info on your official docs on how to intall and update Magysk for A-only devices with LOS and TWRP , https://topjohnwu.github.io/Magisk/ota.html

c) (Optionally): If you want to install any add-ons, click Advanced, then Reboot to Recovery, then when your device reboots, click Apply Update, then Apply from ADB, then adb sideload filename.zip those packages in sequence. > Magisk.zip

Example: https://wiki.lineageos.org/devices/alioth/install