Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor zygisk to use native bridge to inject #6659

Closed
wants to merge 5 commits into from
Closed

Refactor zygisk to use native bridge to inject #6659

wants to merge 5 commits into from

Conversation

yujincheng08
Copy link
Collaborator

@yujincheng08 yujincheng08 commented Mar 1, 2023 •
edited
Loading

TODO

  • Test on more versions of Android with modules
  • Rollback after 3 times zygote crashes
  • resetprop after all zygote starts

close #6920

@vvb2060 vvb2060 removed their request for review March 1, 2023 15:27
canyie
canyie previously requested changes Mar 1, 2023
View reviewed changes
native/src/core/module.cpp Outdated Show resolved Hide resolved
native/src/core/module.cpp Outdated Show resolved Hide resolved
native/src/core/module.cpp Outdated Show resolved Hide resolved
native/src/include/magisk.hpp Outdated Show resolved Hide resolved
native/src/zygisk/hook.cpp Outdated Show resolved Hide resolved
@canyie canyie mentioned this pull request Mar 1, 2023
Closed
This was linked to issues Mar 1, 2023
Magisk Zygisk breaks NDK C++ native breakpoints and stacktraces #6229
Closed
Zygisk modules stacktraces cannot show function name #4776
Closed
@yujincheng08 yujincheng08 force-pushed the zygisk branch 7 times, most recently from 82a7e04 to d95ddb6 Compare March 2, 2023 08:54
@canyie canyie linked an issue Mar 2, 2023 that may be closed by this pull request
Zygisk cannot activate on some old Samsung devices with old kernel (3.19-) #5395
Closed
@yujincheng08 yujincheng08 force-pushed the zygisk branch 3 times, most recently from 2fd4405 to 6fea755 Compare March 3, 2023 15:46
@yujincheng08 yujincheng08 marked this pull request as ready for review March 3, 2023 15:47
@yujincheng08 yujincheng08 requested a review from canyie March 3, 2023 15:47
@yujincheng08 yujincheng08 dismissed canyie’s stale review March 4, 2023 04:45

Sha said she's not reviewing this anymore... So dismiss it for now.

canyie
canyie requested changes Mar 4, 2023
View reviewed changes
native/src/core/module.cpp Outdated Show resolved Hide resolved
native/src/core/module.cpp Outdated Show resolved Hide resolved
native/src/core/module.cpp Outdated Show resolved Hide resolved
native/src/core/module.cpp Outdated Show resolved Hide resolved
native/src/init/rootdir.cpp Outdated Show resolved Hide resolved
native/src/init/rootdir.cpp Outdated Show resolved Hide resolved
native/src/init/rootdir.cpp Outdated Show resolved Hide resolved
native/src/sepolicy/rules.cpp Outdated Show resolved Hide resolved
native/src/zygisk/entry.cpp Outdated Show resolved Hide resolved
native/src/zygisk/hook.cpp Outdated Show resolved Hide resolved
@yujincheng08 yujincheng08 linked an issue Mar 4, 2023 that may be closed by this pull request
Opening apps causes the system to crash and reboot sometimes, if Zygisk is used. #6569
Closed
@yujincheng08 yujincheng08 requested a review from canyie March 4, 2023 15:12
@yujincheng08 yujincheng08 force-pushed the zygisk branch 3 times, most recently from b1d129e to e02ad8d Compare March 4, 2023 15:24
@yujincheng08 yujincheng08 force-pushed the zygisk branch 2 times, most recently from 0a8928e to 720b62a Compare June 6, 2023 16:13
@yujincheng08 yujincheng08 force-pushed the zygisk branch 3 times, most recently from cd80835 to 3c35a1b Compare June 13, 2023 01:33
@yashikada

This comment was marked as off-topic.

Sign in to view
@salvogiangri salvogiangri mentioned this pull request Sep 7, 2023
Closed
@vvb2060 vvb2060 mentioned this pull request Sep 22, 2023
Closed
@vvb2060 vvb2060 closed this Sep 27, 2023
@yujincheng08 yujincheng08 reopened this Oct 16, 2023
@vvb2060 vvb2060 force-pushed the zygisk branch 2 times, most recently from 9c05d5e to f7f16fb Compare October 17, 2023 10:56
@osm0sis osm0sis added enhancement New feature request core This issue is related to Magisk Core labels Oct 24, 2023
@osm0sis osm0sis closed this Oct 28, 2023
@osm0sis osm0sis reopened this Oct 28, 2023
@topjohnwu
Copy link
Owner

Merged into master manually

@topjohnwu topjohnwu closed this Nov 8, 2023
@vvb2060 vvb2060 deleted the zygisk branch February 1, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvb2060 vvb2060 vvb2060 left review comments

@topjohnwu topjohnwu Awaiting requested review from topjohnwu

@canyie canyie Awaiting requested review from canyie

Assignees
No one assigned
Labels
core This issue is related to Magisk Core enhancement New feature request
Projects
None yet
Milestone
No milestone
6 participants
@yujincheng08 @yashikada @topjohnwu @vvb2060 @canyie @osm0sis