-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show CompactionFilter stat #14
Merged
rockeet
merged 2 commits into
topling:topling-8.0.28-2022-11-18-32cc0a03-public
from
gukaifeng:show-compactionfilter-stat
Nov 24, 2022
Merged
show CompactionFilter stat #14
rockeet
merged 2 commits into
topling:topling-8.0.28-2022-11-18-32cc0a03-public
from
gukaifeng:show-compactionfilter-stat
Nov 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockeet
reviewed
Nov 24, 2022
if (m_num_deleted) { | ||
m_fac->m_num_deleted += m_num_deleted; | ||
// Increment stats by num deleted at the end of compaction | ||
rdb_update_global_stats(ROWS_DELETED, m_num_deleted); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不能加 rdb_update_global_stats(ROWS_DELETED),这个已经在执行删除语句的时候执行过了
rockeet
reviewed
Nov 24, 2022
if (auto f = dynamic_cast<const Rdb_compact_filter_factory *>(&fac)) { | ||
json js; | ||
js["class"] = "Rdb_compact_filter_factory"; | ||
js["num expired"] = f->m_num_expired; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
改成 NumExpired, NumDeleted
rockeet
pushed a commit
to rockeet/mysql-5.6
that referenced
this pull request
Nov 24, 2022
* show CompactionFilter stat * add a condition \!IsCompactionWorker()
rockeet
pushed a commit
that referenced
this pull request
May 26, 2023
Summary: This fixes this leak: ``` Direct leak of 74 byte(s) in 2 object(s) allocated from: #0 0x9f235f in malloc #1 0xd88f47 in my_raw_malloc(unsigned long, int) #2 0xd88e1e in my_malloc(unsigned int, unsigned long, int) #3 0xc183e4 in read_ok_ex #4 0xc479d5 in authsm_handle_second_authenticate_user(mysql_async_auth*) #5 0xc32a97 in run_plugin_auth_nonblocking(MYSQL*, char*, unsigned int, char const*, char const*, char const*, char const*, bool) #6 0xc3329a in run_plugin_auth_nonblocking_wrapper #7 0xbfd0de in mysql_change_user_nonblocking #8 0xb7f162 in async_mysql_change_user_wrapper(MYSQL*, char const*, char const*, char const*) #9 0xb7eff1 in mysql_change_user_wrapper(MYSQL*, char const*, char const*, char const*) #10 0xb63882 in do_change_user(st_command*) #11 0xb5ad99 in main #12 0x7fbe8362c656 in __libc_start_call_main #13 0x7fbe8362c717 in __libc_start_main_impl #14 0x94b160 in _start ``` Squash with: D29434855 Reviewed By: jupyung Differential Revision: D43006844 fbshipit-source-id: 254272b369fccc39e1c866a5d179a3c7401942eb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.