This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Update prepublish for latest upstream data #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Supercedes https://github.com/topojson/world-atlas/pull/21/files , which does not update the IDs used in the TopoJSON. |
|
As this repository is not active, in the mean time I'm using https://github.com/fil/visionscarto-world-atlas by @Fil, which has these and other fixes. |
|
I’ve updated to version 4.1.0 of Natural Earth Data in 5044ad1. Thanks for the suggestion. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While attempting to generate a build from the latest upstream Natural Earth data, I noticed all the fields are now upper case. This change makes it so the prepublish script works again, and can be used to publish a new release.
Using these upper case fields would merit a major release, as the TSV header row will change. Alternatively, the script could rename them to lower case for backwards compatibility (not done in this PR).
Closes #24