Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes and enhance zkEVM demo #34

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

wyhaines
Copy link
Collaborator

@wyhaines wyhaines commented Mar 5, 2024

Fix a couple bugs in the codeblock implementation, and switch the local zkevm demo page to use it, with trimming of the text to be cut and pasted to avoid pasting things other than the command to run.

Description

Change the code blocks so that instead of this:

image

which, on a copy, gets all of the extra non-command stuff, like the $ at the start of a line, or the <tx_hash>, or all of the extraneous command output, to this:

image

where the 'Copy' button only copies the topos-zkevm-demo generate merkle-proof or the topos-zkevm-demo generate merkle-proof 0x785102ca9881b284588452cd90685d2c713cf61f6e4f3fcc8451bb6f2a571130, respectively.

Similar changes are applied to all of the code blocks. This dramatically improves the user experience of going through the demo, as people can copy and paste from the content in the developer docs without having to manually edit every line that they copy before running it.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

Fix a couple bugs in the codeblock implementation, and switch the local zkevm demo page to use it, with trimming of the text to be cut and pasted to avoid pasting things other than the command to run.
Copy link

netlify bot commented Mar 5, 2024

Deploy Preview for toposware-docs-platform ready!

Name Link
🔨 Latest commit f3611da
🔍 Latest deploy log https://app.netlify.com/sites/toposware-docs-platform/deploys/65e68229a28c5c0008caf30e
😎 Deploy Preview https://deploy-preview-34--toposware-docs-platform.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wyhaines wyhaines merged commit be62ee8 into main Mar 5, 2024
4 checks passed
@wyhaines wyhaines deleted the kh.small-fixes-to-local-zkevm-demo branch March 5, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant