Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tests #34

Merged
merged 1 commit into from Mar 6, 2024
Merged

Refactor tests #34

merged 1 commit into from Mar 6, 2024

Conversation

Nashtare
Copy link
Member

@Nashtare Nashtare commented Feb 27, 2024 •
edited

Description

This PR refactors tests from the key_generation module to reduce code duplication. It particular:

  • it moves the do_keygen helper method for testing from signature to key_generation and adds some additional sanity checks within
  • reuses it for regular scenarios testing (i.e. no failures)
  • adds two edge cases checks (i.e. resharing from a single party and to a single party)

closes #29

@Nashtare Nashtare self-assigned this Feb 27, 2024
@Nashtare
Copy link
Member Author

Code coverage error on this PR and previous ones is unrelated, and seems to be coming from xd009642/tarpaulin#1282.

@Nashtare Nashtare requested a review from hratoanina March 4, 2024 13:07
hratoanina
hratoanina approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@hratoanina hratoanina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

src/dkg/key_generation.rs Show resolved Hide resolved
@Nashtare Nashtare merged commit ccc7e19 into main Mar 6, 2024
7 of 8 checks passed
@Nashtare Nashtare deleted the test_cleanup branch March 6, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hratoanina hratoanina hratoanina approved these changes

Assignees

@Nashtare Nashtare

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor key generation module testing suite
2 participants
@Nashtare @hratoanina