Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

一箇所間違いっぽい。 #41

Closed
kenjihiranabe opened this issue Dec 8, 2023 · 2 comments
Closed

一箇所間違いっぽい。 #41

kenjihiranabe opened this issue Dec 8, 2023 · 2 comments

Comments

@kenjihiranabe
Copy link
Collaborator

https://github.com/toppers/hakoniwa-px4sim/blob/c1d1faf51ad90d2d1f7a9ddff0fce92759e47217/hakoniwa/src/assets/drone/physics/ground_frame/drone_dynamics_ground_frame.cpp#L30C149-L30C150

s_psy は c_psi の間違いっぽい。。。確認ください。

@tmori
Copy link
Contributor

tmori commented Dec 8, 2023

https://github.com/toppers/hakoniwa-px4sim/blob/c1d1faf51ad90d2d1f7a9ddff0fce92759e47217/hakoniwa/src/assets/drone/physics/ground_frame/drone_dynamics_ground_frame.cpp#L30C149-L30C150

s_psy は c_psi の間違いっぽい。。。確認ください。

ご確認いただき、ありがとうございます!確認しました。

バグ:

  • (thrust.data / this->param_mass ) * ( this->cache.cos_phi * this->cache.sin_theta * this->cache.sin_psi - this->cache.sin_phi * this->cache.sin_psi )

正しい:

  • (thrust.data / this->param_mass ) * ( this->cache.cos_phi * this->cache.sin_theta * this->cache.sin_psi - this->cache.sin_phi * this->cache.cos_psi )

これが一致しない原因かもですね。確認してみます!!

@tmori
Copy link
Contributor

tmori commented Dec 8, 2023

以下で修正しました。

#42

@tmori tmori closed this as completed in 1f10bd3 Dec 8, 2023
tmori added a commit that referenced this issue Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants