Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated methods and rake tasks #769

Merged
merged 9 commits into from Mar 15, 2021

Conversation

Vitalina-Vakulchyk
Copy link
Contributor

@Vitalina-Vakulchyk Vitalina-Vakulchyk commented Mar 11, 2021

Remote methods and rake tasks, that marked as deprecated.

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the changelog if the new code introduces user-observable changes. See changelog entry format for details.

lib/chewy/index.rb Show resolved Hide resolved
lib/chewy/index.rb Outdated Show resolved Hide resolved
CHANGELOG.md Outdated
Comment on lines 9 to 18
* [#769](https://github.com/toptal/chewy/pull/769): **(Breaking)** Remove `Chewy::Index.index_params`, use `Chewy::Index.specification_hash` instead ([@Vitalina-Vakulchyk][])
* [#769](https://github.com/toptal/chewy/pull/769): **(Breaking)** Remove `Chewy::Index.derivable_index_name`, use `Chewy::Index.derivable_name` instead ([@Vitalina-Vakulchyk][])
* [#769](https://github.com/toptal/chewy/pull/769): **(Breaking)** Remove `Chewy::Index.build_index_name`, use `Chewy::Index.index_name` instead ([@Vitalina-Vakulchyk][])
* [#769](https://github.com/toptal/chewy/pull/769): **(Breaking)** Remove `Chewy::RakeHelper.reset_index`, use `Chewy::RakeHelper.reset` instead ([@Vitalina-Vakulchyk][])
* [#769](https://github.com/toptal/chewy/pull/769): **(Breaking)** Remove `Chewy::RakeHelper.reset_all`, use `Chewy::RakeHelper.reset` instead ([@Vitalina-Vakulchyk][])
* [#769](https://github.com/toptal/chewy/pull/769): **(Breaking)** Remove `Chewy::RakeHelper.update_index`, use `Chewy::RakeHelper.update` instead ([@Vitalina-Vakulchyk][])
* [#769](https://github.com/toptal/chewy/pull/769): **(Breaking)** Remove `Chewy::RakeHelper.update_all`, use `Chewy::RakeHelper.update` instead ([@Vitalina-Vakulchyk][])
* [#769](https://github.com/toptal/chewy/pull/769): **(Breaking)** Remove `rake chewy:apply_changes_from`, use `rake chewy:journal:apply` instead ([@Vitalina-Vakulchyk][])
* [#769](https://github.com/toptal/chewy/pull/769): **(Breaking)** Remove `rake chewy:clean_journal`, use `rake chewy:journal:clean` instead ([@Vitalina-Vakulchyk][])

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [#769](https://github.com/toptal/chewy/pull/769): **(Breaking)** Remove `Chewy::Index.index_params`, use `Chewy::Index.specification_hash` instead ([@Vitalina-Vakulchyk][])
* [#769](https://github.com/toptal/chewy/pull/769): **(Breaking)** Remove `Chewy::Index.derivable_index_name`, use `Chewy::Index.derivable_name` instead ([@Vitalina-Vakulchyk][])
* [#769](https://github.com/toptal/chewy/pull/769): **(Breaking)** Remove `Chewy::Index.build_index_name`, use `Chewy::Index.index_name` instead ([@Vitalina-Vakulchyk][])
* [#769](https://github.com/toptal/chewy/pull/769): **(Breaking)** Remove `Chewy::RakeHelper.reset_index`, use `Chewy::RakeHelper.reset` instead ([@Vitalina-Vakulchyk][])
* [#769](https://github.com/toptal/chewy/pull/769): **(Breaking)** Remove `Chewy::RakeHelper.reset_all`, use `Chewy::RakeHelper.reset` instead ([@Vitalina-Vakulchyk][])
* [#769](https://github.com/toptal/chewy/pull/769): **(Breaking)** Remove `Chewy::RakeHelper.update_index`, use `Chewy::RakeHelper.update` instead ([@Vitalina-Vakulchyk][])
* [#769](https://github.com/toptal/chewy/pull/769): **(Breaking)** Remove `Chewy::RakeHelper.update_all`, use `Chewy::RakeHelper.update` instead ([@Vitalina-Vakulchyk][])
* [#769](https://github.com/toptal/chewy/pull/769): **(Breaking)** Remove `rake chewy:apply_changes_from`, use `rake chewy:journal:apply` instead ([@Vitalina-Vakulchyk][])
* [#769](https://github.com/toptal/chewy/pull/769): **(Breaking)** Remove `rake chewy:clean_journal`, use `rake chewy:journal:clean` instead ([@Vitalina-Vakulchyk][])
* [#769](https://github.com/toptal/chewy/pull/769): **(Breaking)** Removal of deprecated methods and rake tasks ([@Vitalina-Vakulchyk][]):
* `Chewy::Index.index_params` is removed, use `Chewy::Index.specification_hash` instead
* `Chewy::Index.derivable_index_name` is removed, use `Chewy::Index.derivable_name` instead
* `Chewy::Index.default_prefix` is removed, use `Chewy::Index.prefix` instead
* `Chewy::Index.build_index_name` is removed, use `Chewy::Index.index_name` instead
* `Chewy::RakeHelper.reset_index` is removed, use `Chewy::RakeHelper.reset` instead
* `Chewy::RakeHelper.reset_all` is removed, use `Chewy::RakeHelper.reset` instead
* `Chewy::RakeHelper.update_index` is removed, use `Chewy::RakeHelper.update` instead
* `Chewy::RakeHelper.update_all` is removed, use `Chewy::RakeHelper.update` instead
* `rake chewy:apply_changes_from` is removed, use `rake chewy:journal:apply` instead
* `rake chewy:clean_journal` is removed, use `rake chewy:journal:clean` instead

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably something like this should be added to the upgrade/migration notes as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably something like this should be added to the upgrade/migration notes as well.

Actually, they all have been deprecated since 2017. I think it should be safe just to drop them finally, with a note in the CHANGELOG only.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, I have just updated CHANLOG again.
I can do more changes if needed.

CHANGELOG.md Outdated Show resolved Hide resolved
@rabotyaga rabotyaga merged commit f5bad9f into master Mar 15, 2021
@rabotyaga rabotyaga deleted the remove-deprecated-methods-and-tasks branch March 15, 2021 08:14
cyucelen pushed a commit to cyucelen/chewy that referenced this pull request Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants