Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in mock_elasticsearch_response_sources #861

Merged
merged 4 commits into from Apr 20, 2023

Conversation

lafeber
Copy link
Contributor

@lafeber lafeber commented Oct 19, 2022

The "_id" is currently the incrementing id from the each_with_index loop. However, this id is eventually used in the all_scope_where_ids_in method, where it subsequently fails.

If you add id: ... to your hits that are passed as a parameter in the mock_elasticsearch_response_sources method, this helper method now works.

Fixes #862


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the changelog if the new code introduces user-observable changes. See changelog entry format for details.

@lafeber
Copy link
Contributor Author

lafeber commented Dec 16, 2022

@konalegi do you have time to look at this?

@konalegi konalegi closed this Dec 16, 2022
@konalegi konalegi reopened this Dec 16, 2022
@konalegi
Copy link
Contributor

GitHub actions are stuck, let me try them run first. Not sure why they are not starting.

@konalegi
Copy link
Contributor

@lafeber could you please rebase your branch with the master?

@konalegi
Copy link
Contributor

Also, please provide a changelog entry, so that will be easier to generate a release (example)

@konalegi konalegi self-requested a review December 23, 2022 07:18
@konalegi konalegi closed this Mar 20, 2023
@konalegi konalegi reopened this Mar 20, 2023
@lafeber
Copy link
Contributor Author

lafeber commented Apr 20, 2023

@konalegi I'm sorry this issue disappeared from my radar. I've updated with master and added a changelog entry.

@konalegi konalegi merged commit c20d112 into toptal:master Apr 20, 2023
13 checks passed
@konalegi
Copy link
Contributor

@lafeber thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in the mock_elasticsearch_response_sources method
2 participants