Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix intermittent time-based failure in delayed sidekiq spec #947

Merged
merged 2 commits into from
May 2, 2024
Merged

Fix intermittent time-based failure in delayed sidekiq spec #947

merged 2 commits into from
May 2, 2024

Commits on May 1, 2024

  1. Fix intermittent time-based failure in delayed sidekiq spec 

    This example was previously failing when it was run at exactly an "even"
10 second increment time. For example, it would fail at "12:00:10", but
pass at "12:00:09" and "12:00:11". This leads to intermittent failures
on CI (presumably around ~10% of runs).

Updated to use a helper method in the spec which more closely mirrors
the scheduler code.
    @mjankowski
    mjankowski committed May 1, 2024
    Configuration menu
    Copy the full SHA
    ea63df1 View commit details
    Browse the repository at this point in the history

  2. Add changelog notes

    @mjankowski
    mjankowski committed May 1, 2024
    Configuration menu
    Copy the full SHA
    a68d43c View commit details
    Browse the repository at this point in the history