Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump swift from v4.1 to v4.2.4 #500

Merged
merged 1 commit into from Jul 28, 2020
Merged

Bump swift from v4.1 to v4.2.4 #500

merged 1 commit into from Jul 28, 2020

Conversation

achwedyk
Copy link
Contributor

Bumps swift to the latest available version in v4 branch.

To test manually:

docker-compose up --build

visit http://localhost:8080

gobr
gobr approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@gobr gobr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and worked without issues.

@achwedyk achwedyk mentioned this pull request Jul 28, 2020
Closed
berthj193
berthj193 approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@berthj193 berthj193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker-compose up --build (prod) and docker-compose -f ./docker-compose-dev.yml up --build work as expected 🚀

@achwedyk achwedyk merged commit d3dc737 into master Jul 28, 2020
@achwedyk achwedyk deleted the upgrade-swift-to-4-2-4 branch July 28, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gobr gobr gobr approved these changes

@berthj193 berthj193 berthj193 approved these changes

@MarianoSalerno MarianoSalerno Awaiting requested review from MarianoSalerno

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@achwedyk @gobr @berthj193