Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run type check in visual tests #1194

Closed
wants to merge 1 commit into from

Conversation

havenchyk
Copy link
Contributor

Just experiments, do not review

@havenchyk havenchyk force-pushed the do-not-run-type-check-in-visual-tests branch from 39a48ec to 290388f Compare March 30, 2020 07:31
@toptal-devbot
Copy link
Collaborator

Fails
🚫

Danger failed to run /app/node_modules/@toptal/davinci-ci/src/configs/danger/dangerfile.js.

Error Error

[BABEL] /app/commitlint.config.js: Using `babel-preset-react-app` requires that you specify `NODE_ENV` or `BABEL_ENV` environment variables. Valid values are "development", "test", and "production". Instead, received: undefined. (While processing: "/app/node_modules/babel-preset-react-app/index.js")
Error: [BABEL] /app/commitlint.config.js: Using `babel-preset-react-app` requires that you specify `NODE_ENV` or `BABEL_ENV` environment variables. Valid values are "development", "test", and "production". Instead, received: undefined. (While processing: "/app/node_modules/babel-preset-react-app/index.js")
    at module.exports (/app/node_modules/babel-preset-react-app/create.js:58:11)
    at module.exports (/app/node_modules/babel-preset-react-app/index.js:19:10)
    at /app/node_modules/@babel/core/lib/config/full.js:199:14
    at Generator.next (<anonymous>)
    at Function.<anonymous> (/app/node_modules/@babel/core/lib/gensync-utils/async.js:26:3)
    at Generator.next (<anonymous>)
    at evaluateSync (/app/node_modules/gensync/index.js:244:28)
    at Function.sync (/app/node_modules/gensync/index.js:84:14)
    at sync (/app/node_modules/@babel/core/lib/gensync-utils/async.js:66:25)
    at sync (/app/node_modules/gensync/index.js:177:19)

Dangerfile

-------------^

Generated by 🚫 dangerJS against 290388f

@toptal-devbot
Copy link
Collaborator

🎉 Last commit is successfully deployed 🎉

Demo is available on:

Your davinci-bot 🚀

@havenchyk havenchyk closed this Jul 7, 2020
@havenchyk havenchyk deleted the do-not-run-type-check-in-visual-tests branch July 7, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants