Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use fixed month for Calendar stories #3720

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

sashuk
Copy link
Contributor

@sashuk sashuk commented Jul 12, 2023

No Jira ticket.

Description

This pull request sets fixed date values for Calendar stories so they do not cause diffs in visual testing (related to https://happo.io/a/675/p/1189/compare/0ecdbb4cfa3fb2129776c985c4bff3a6bce48efa/a88bad139b9361f0b7a5ba47b9b9fe4dfccff10f and https://toptal-core.slack.com/archives/GG3F4AS4T/p1689155367432289).

How to test

  • All tests should pass

Development checks

  • [N/A] Add changeset according to guidelines (if needed)
  • Read CONTRIBUTING.md and Component API principles
  • [N/A] Make sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
  • [N/A] Annotate all props in component with documentation
  • [N/A] Create examples for component
  • Ensure that deployed demo has expected results and good examples
  • [N/A] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
  • Self reviewed
  • [N/A] Covered with tests

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@sashuk sashuk self-assigned this Jul 12, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2023

⚠️ No Changeset found

Latest commit: a3936e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sashuk sashuk marked this pull request as ready for review July 12, 2023 11:25
@sashuk sashuk requested a review from a team as a code owner July 12, 2023 11:25
@sashuk sashuk force-pushed the FX-NULL-use-fixes-month-for-calendar-stories branch 2 times, most recently from 1c9f62b to 02c09a7 Compare July 12, 2023 11:25
@sashuk sashuk added the no-jira label Jul 12, 2023
@toptal-devbot toptal-devbot temporarily deployed to temploy July 12, 2023 11:37 Inactive
@sashuk sashuk force-pushed the FX-NULL-use-fixes-month-for-calendar-stories branch from 02c09a7 to c189e74 Compare July 12, 2023 11:38
@sashuk sashuk force-pushed the FX-NULL-use-fixes-month-for-calendar-stories branch from c189e74 to a3936e5 Compare July 12, 2023 11:38
@toptal-devbot toptal-devbot temporarily deployed to temploy July 12, 2023 11:51 Inactive
@sashuk
Copy link
Contributor Author

sashuk commented Jul 12, 2023

@toptal-anvil ping reviewers

@mkrl mkrl requested a review from a team July 12, 2023 12:05
@sashuk sashuk merged commit 68c7a39 into master Jul 12, 2023
18 checks passed
@sashuk sashuk deleted the FX-NULL-use-fixes-month-for-calendar-stories branch July 12, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants