-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(comm): extend application update notification component to match new BASE #3725
feat(comm): extend application update notification component to match new BASE #3725
Conversation
🦋 Changeset detectedLatest commit: 0bb1daa The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Greetings from FX team, @alexvcasillas 👋 Thank you so much for contributing 🙇 We have got high priority ticket generated on our Kanban board so we will do our best to make your experience supreme! What's next? We will collaborate using this workflow. For you this practically means making sure DONE criteria is met and responding promptly to code review comments 😉 🙏 please, help us improve, rate your contributing experience after merge |
@toptal-anvil ping reviewers |
Note: Until we have the BASE specs for this updated component we should not merge this |
Hey @alexvcasillas any update on this? |
Yes @TomasSlama , we're going to be working on this in the next sprint :) |
@toptal-anvil ping reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment, that needs to be addressed. I'm also not sure about the actionsAlignment
, I want to know opinion about it from my colleagues, I will raise it today on daily, I will let you know
packages/picasso/src/ApplicationUpdateNotification/ApplicationUpdateNotification.tsx
Outdated
Show resolved
Hide resolved
Hey @TomasSlama I've added that property so we can have some room for flexibility because on the early design of this component, the buttons were alignment on the left on the initial state of the dismissable modal and on the right when the modal becomes undismissable :) |
packages/picasso/src/ApplicationUpdateNotification/story/index.jsx
Outdated
Show resolved
Hide resolved
@toptal-anvil ping reviewers |
packages/picasso/src/ApplicationUpdateNotificationActions/test.tsx
Outdated
Show resolved
Hide resolved
packages/picasso/src/ApplicationUpdateNotificationActions/__snapshots__/test.tsx.snap
Outdated
Show resolved
Hide resolved
...es/picasso/src/ApplicationUpdateNotificationActions/ApplicationUpdateNotificationActions.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor comments
6b707b8
to
5f2858f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing all the suggestions!
I have one final thing that I think should be fixed and then we can merge it 💪
packages/picasso/src/ApplicationUpdateNotification/story/index.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job 👍
COMM-2458 & COMM-2634
Description
When it comes to displaying the user that there’s a mandatory update and that they need to refresh whether they like it or not, we should be using the ApplicationUpdateNotification component provided by Picasso that follows BASE. But this component is not extensible enough and it does not give room for customization as we have various requirements that need to be fulfilled in order to be able to satisfy the requirements that we’re aiming for with the Force Refresh initiative.
How to test
BASE design 👉🏻 https://www.figma.com/file/vVoOW3YNKJkvRV3RAMPF3Y/Talent-Portal-Library?type=design&node-id=4612-37156&mode=design&t=r0mYhMpZA9tD0VjW-0
Screenshots
Development checks
props
in component with documentationexamples
for componentBreaking change
n/a
test alpha package of Picasso in StaffPortalPR commands
List of available commands:
@toptal-bot run package:alpha-release
- Release alpha version@toptal-anvil ping reviewers
- Ping FX team for reviewPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:
to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle
)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?