Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: return RTE toolbar id for feature tests #3733

Merged
merged 3 commits into from
Jul 20, 2023

Conversation

TomasSlama
Copy link
Contributor

@TomasSlama TomasSlama commented Jul 19, 2023

FX-4172

Description

For backward compatibility, we need to keep the HTML structure closest as possible to the previous version. In feature tests, they are using the id of the toolbar as a selector.

How to test

  • Temploy
  • FIXME: Add the steps describing how to verify your changes

Screenshots

Before. After.
Insert screenshots or screen recordings Insert screenshots or screen recordings

Development checks

Breaking change

  • codemod is created and showcased in the changeset
  • test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@changeset-bot
Copy link

changeset-bot bot commented Jul 19, 2023

🦋 Changeset detected

Latest commit: 52345c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@toptal/picasso-rich-text-editor Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@TomasSlama TomasSlama self-assigned this Jul 19, 2023
@TomasSlama
Copy link
Contributor Author

@toptal-bot run package:alpha-release

@toptal-devbot
Copy link
Collaborator

Your alpha package is ready 🎉
yarn add @topkit/analytics-charts@48.0.1-alpha-fx-4172-return-toolbar-id-274cd34eb.9+274cd34eb
yarn add @toptal/picasso@37.1.1-alpha-fx-4172-return-toolbar-id-274cd34eb.4+274cd34eb
yarn add @toptal/picasso-charts@51.0.1-alpha-fx-4172-return-toolbar-id-274cd34eb.9+274cd34eb
yarn add @toptal/picasso-codemod@5.5.3-alpha-fx-4172-return-toolbar-id-274cd34eb.20+274cd34eb
yarn add @toptal/picasso-forms@60.0.1-alpha-fx-4172-return-toolbar-id-274cd34eb.1+274cd34eb
yarn add @toptal/picasso-pictograms@1.1.2-alpha-fx-4172-return-toolbar-id-274cd34eb.95+274cd34eb
yarn add @toptal/picasso-provider@3.1.3-alpha-fx-4172-return-toolbar-id-274cd34eb.84+274cd34eb
yarn add @toptal/picasso-rich-text-editor@4.0.1-alpha-fx-4172-return-toolbar-id-274cd34eb.1+274cd34eb
yarn add @toptal/picasso-shared@12.0.1-alpha-fx-4172-return-toolbar-id-274cd34eb.140+274cd34eb

@toptal-devbot toptal-devbot temporarily deployed to temploy July 19, 2023 14:10 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy July 20, 2023 11:45 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy July 20, 2023 12:19 Inactive
@TomasSlama TomasSlama marked this pull request as ready for review July 20, 2023 12:36
@TomasSlama TomasSlama requested a review from a team as a code owner July 20, 2023 12:36
@TomasSlama
Copy link
Contributor Author

@toptal-anvil ping reviewers

@toptal-devbot toptal-devbot temporarily deployed to temploy July 20, 2023 12:49 Inactive
@TomasSlama TomasSlama merged commit bbea3a6 into master Jul 20, 2023
18 checks passed
@TomasSlama TomasSlama deleted the fx-4172-return-toolbar-id branch July 20, 2023 13:11
@toptal-build toptal-build mentioned this pull request Jul 20, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants