Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX-5185] Use twMerge in Typography #4307

Merged
merged 2 commits into from
May 27, 2024

Conversation

ruslan-sed
Copy link
Contributor

@ruslan-sed ruslan-sed commented May 16, 2024

FX-5185

Description

Replace classnames with twMerge in Typography.

How to test

  • Temploy
  • FIXME: Add the steps describing how to verify your changes

Development checks

Breaking change

  • codemod is created and showcased in the changeset
  • test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

Copy link

changeset-bot bot commented May 16, 2024

🦋 Changeset detected

Latest commit: 74f174d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 60 packages
Name Type
@toptal/picasso-typography Patch
@toptal/picasso-query-builder Patch
@toptal/picasso-rich-text-editor Patch
@toptal/picasso Patch
@topkit/analytics-charts Patch
@toptal/picasso-account-select Patch
@toptal/picasso-alert Patch
@toptal/picasso-amount Patch
@toptal/picasso-application-update-notification Patch
@toptal/picasso-autocomplete Patch
@toptal/picasso-avatar Patch
@toptal/picasso-breadcrumbs Patch
@toptal/picasso-calendar Patch
@toptal/picasso-drawer Patch
@toptal/picasso-dropzone Patch
@toptal/picasso-empty-state Patch
@toptal/picasso-file-input Patch
@toptal/picasso-form Patch
@toptal/picasso-grid Patch
@toptal/picasso-helpbox Patch
@toptal/picasso-list Patch
@toptal/picasso-menu Patch
@toptal/picasso-modal Patch
@toptal/picasso-note Patch
@toptal/picasso-notification Patch
@toptal/picasso-overview-block Patch
@toptal/picasso-page Patch
@toptal/picasso-pagination Patch
@toptal/picasso-prompt-modal Patch
@toptal/picasso-quote Patch
@toptal/picasso-section Patch
@toptal/picasso-select Patch
@toptal/picasso-show-more Patch
@toptal/picasso-step Patch
@toptal/picasso-table Patch
@toptal/picasso-tabs Patch
@toptal/picasso-tag Patch
@toptal/picasso-timeline Patch
@toptal/picasso-tooltip Patch
@toptal/picasso-typography-overflow Patch
@toptal/picasso-user-badge Patch
@toptal/picasso-forms Patch
@toptal/picasso-tagselector Patch
@toptal/picasso-avatar-upload Patch
@toptal/picasso-date-picker Patch
@toptal/picasso-checkbox Patch
@toptal/picasso-input Patch
@toptal/picasso-number-input Patch
@toptal/picasso-radio Patch
@toptal/picasso-switch Patch
@toptal/picasso-date-select Patch
@toptal/picasso-slider Patch
@toptal/picasso-button Patch
@toptal/picasso-password-input Patch
@toptal/picasso-timepicker Patch
@toptal/picasso-accordion Patch
@toptal/picasso-carousel Patch
@toptal/picasso-outlined-input Patch
@toptal/picasso-skeleton-loader Patch
@toptal/picasso-tree-view Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ruslan-sed ruslan-sed self-assigned this May 16, 2024
@ruslan-sed ruslan-sed force-pushed the fx-5185-use-twmerge-in-typography branch 7 times, most recently from 2c567f8 to e3fdddf Compare May 24, 2024 10:12
@ruslan-sed ruslan-sed force-pushed the fx-5185-use-twmerge-in-typography branch from f07dc34 to e3fdddf Compare May 27, 2024 07:40
@ruslan-sed ruslan-sed force-pushed the fx-5185-use-twmerge-in-typography branch from e3fdddf to 4f9c233 Compare May 27, 2024 07:46
@ruslan-sed ruslan-sed marked this pull request as ready for review May 27, 2024 08:07
@ruslan-sed ruslan-sed requested a review from a team as a code owner May 27, 2024 08:07
@ruslan-sed
Copy link
Contributor Author

@toptal-anvil ping reviewers

@ruslan-sed ruslan-sed force-pushed the fx-5185-use-twmerge-in-typography branch from 944f182 to 74f174d Compare May 27, 2024 08:35
@TomasSlama TomasSlama requested a review from a team May 27, 2024 08:57
Copy link
Member

@mkrl mkrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Both visual tests and code look good.

@ruslan-sed ruslan-sed merged commit 2820f38 into master May 27, 2024
18 checks passed
@ruslan-sed ruslan-sed deleted the fx-5185-use-twmerge-in-typography branch May 27, 2024 11:32
@toptal-build toptal-build mentioned this pull request May 27, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants