-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FX-5185] Use twMerge in Typography #4307
Conversation
🦋 Changeset detectedLatest commit: 74f174d The changes in this PR will be included in the next version bump. This PR includes changesets to release 60 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2c567f8
to
e3fdddf
Compare
f07dc34
to
e3fdddf
Compare
e3fdddf
to
4f9c233
Compare
@toptal-anvil ping reviewers |
944f182
to
74f174d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! Both visual tests and code look good.
FX-5185
Description
Replace
classnames
withtwMerge
inTypography
.How to test
Development checks
props
in component with documentationexamples
for componentBreaking change
codemod is created and showcased in the changesettest alpha package of Picasso in StaffPortalPR commands
List of available commands:
@toptal-bot run package:alpha-release
- Release alpha version@toptal-anvil ping reviewers
- Ping FX team for reviewPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:
to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle
)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?