Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX-4718] Remove deprecated props #4369

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

mkrl
Copy link
Member

@mkrl mkrl commented Jun 18, 2024

FX-4718

Description

Removes deprecated props from TreeView.
There are no usages of the prop across the entire org.

How to test

  • Temploy
  • CI should pass, no other changes

Development checks

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@mkrl mkrl self-assigned this Jun 18, 2024
@mkrl mkrl requested a review from a team as a code owner June 18, 2024 10:48
Copy link

changeset-bot bot commented Jun 18, 2024

🦋 Changeset detected

Latest commit: 212ed0d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@toptal/picasso-tree-view Major
@toptal/picasso Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mkrl
Copy link
Member Author

mkrl commented Jun 18, 2024

@toptal-anvil ping reviewers

@AdrianContiu AdrianContiu self-requested a review June 20, 2024 08:05
Copy link
Contributor

@AdrianContiu AdrianContiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

packages/base/TreeView/src/TreeView/TreeView.tsx Outdated Show resolved Hide resolved
@TomasSlama
Copy link
Contributor

@sashuk @mkrl should we merge this to master? or should we merge it as bulk for all depreciation removal?

@sashuk
Copy link
Contributor

sashuk commented Jun 20, 2024

@TomasSlama I think it is fine to merge to master

@mkrl mkrl enabled auto-merge (squash) June 20, 2024 12:02
@mkrl mkrl merged commit 08cfcd4 into master Jun 20, 2024
18 checks passed
@mkrl mkrl deleted the fx-4718-remove-deprecated-treeview-props branch June 20, 2024 12:23
@toptal-build toptal-build mentioned this pull request Jun 20, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants