Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert davinci-github-actions/build-push-image update #4387

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

sashuk
Copy link
Contributor

@sashuk sashuk commented Jun 24, 2024

Description

This pull request reverts the toptal/davinci-github-actions/build-push-image bump to solve the problem described here.

How to test

  • Temploy
  • Run the command below locally (the image is built from this pull request), there should be no errors
docker run --rm -v /var/lib/jenkins/workspace/picasso-docs/deploy-docs:/app/deploy-docs -e DEPLOY_DOCS_PATH=/app/deploy-docs -e DEPLOY_DOCS_ARCHIVE=deploy-docs us-central1-docker.pkg.dev/toptal-hub/containers/picasso:dcdbe16f9fb143100c91493b1e1ac760c8585ee1 ./bin/release-docs

Development checks

  • [N/A] Add changeset according to guidelines (if needed)
  • Ensure that deployed demo has expected results and good examples
  • Self reviewed

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@sashuk sashuk added the no-jira label Jun 24, 2024
@sashuk sashuk self-assigned this Jun 24, 2024
@sashuk sashuk requested a review from a team as a code owner June 24, 2024 16:00
Copy link

changeset-bot bot commented Jun 24, 2024

⚠️ No Changeset found

Latest commit: dcdbe16

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sashuk sashuk changed the title Revert toptal/davinci-github-actions/build-push-image update Revert davinci-github-actions/build-push-image update Jun 24, 2024
@sashuk
Copy link
Contributor Author

sashuk commented Jun 24, 2024

@toptal-anvil ping reviewers

@sashuk sashuk merged commit 6d570f9 into master Jun 25, 2024
20 of 21 checks passed
@sashuk sashuk deleted the FX-NULL-revert-github-actions-update branch June 25, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants