Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX-5570] Use our Backdrop #4391

Merged
merged 1 commit into from
Jun 27, 2024
Merged

[FX-5570] Use our Backdrop #4391

merged 1 commit into from
Jun 27, 2024

Conversation

TomasSlama
Copy link
Contributor

@TomasSlama TomasSlama commented Jun 27, 2024

FX-5570

Description

Describe the changes and motivations for the pull request.

How to test

  • Temploy
  • FIXME: Add the steps describing how to verify your changes

Screenshots

Before. After.
Insert screenshots or screen recordings Insert screenshots or screen recordings

Development checks

Breaking change

  • codemod is created and showcased in the changeset
  • test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@TomasSlama TomasSlama self-assigned this Jun 27, 2024
@TomasSlama TomasSlama requested a review from a team as a code owner June 27, 2024 12:55
Copy link

changeset-bot bot commented Jun 27, 2024

🦋 Changeset detected

Latest commit: fcb35eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@toptal/picasso-drawer Patch
@toptal/picasso Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@TomasSlama TomasSlama changed the title Use our Backdrop [FX-5570] Use our Backdrop Jun 27, 2024
@TomasSlama TomasSlama merged commit 34097ae into master Jun 27, 2024
17 of 18 checks passed
@TomasSlama TomasSlama deleted the fx-null-use-our-backdrop branch June 27, 2024 13:22
@toptal-build toptal-build mentioned this pull request Jun 27, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant