Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generic VPU example #15

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Add generic VPU example #15

merged 3 commits into from
Jan 24, 2024

Conversation

embdur
Copy link
Contributor

@embdur embdur commented Dec 17, 2023

Signed-off-by: Abdur Rehman abdur.rehman@toradex.com

embdur
embdur commented Dec 17, 2023
View reviewed changes
samples.json Show resolved Hide resolved
@leonheldattoradex
Copy link
Contributor

Is there any reason to include the source code of linux-imx-headers instead of using https://feeds.toradex.com/debian/pool/non-free/l/linux-imx-headers/?

@leonheldattoradex
Copy link
Contributor

My comments are mostly infrastructure-related, and I'm not the gatekeeper for this branch, so I'll just leave my comments at that.
I have a bunch of reservations regarding how the samples are structured (repetition and non-portability of pwsh scripts, sharing key pairs for ssh) but these are not related to the MR.

@embdur
Copy link
Contributor Author

embdur commented Jan 2, 2024

@leonheldattoradex

Is there any reason to include the source code of linux-imx-headers instead of using https://feeds.toradex.com/debian/pool/non-free/l/linux-imx-headers/?

Oh my, that's a chonky left over from an experiment. I will remove it.

This was referenced Jan 2, 2024
Closed
Open
@leograba
Copy link
Contributor

Guys, I lost track of this a bit. Is there anything blocking?

@embdur embdur marked this pull request as draft January 16, 2024 14:01
@embdur
Copy link
Contributor Author

embdur commented Jan 18, 2024

Fixed issues around linux-imx-headers and gpg key. Now rebasing against latest default template.

@embdur embdur force-pushed the tccp-26 branch 2 times, most recently from 506e4f0 to 5106b5e Compare January 22, 2024 19:57
@embdur embdur marked this pull request as ready for review January 22, 2024 20:37
@embdur
Copy link
Contributor Author

embdur commented Jan 22, 2024

  • now using linux-imx-headers-dev instead of copying the headers manually
  • reused GPG key
  • updated the base template manually

Sanity testing: Tested the sample on all three supported targets(verdin-imx8mm , verdin-imx8mp and apalis-imx8.

@embdur
Copy link
Contributor Author

embdur commented Jan 23, 2024

Added .conf/.template manually to the base template commit.

@embdur
vpu: Generic: Initial generic base template commit
8654e70 
Generated using Torizon IDE Extension Pre-Release v2.3.117.

Signed-off-by: Abdur Rehman <abdur.rehman@toradex.com>
@embdur
vpu: Generic: Add VPU example for i.MX8
4761654 
Tested on verdin-imx8mm, verdin-imx8mp and apalis-imx8.

Signed-off-by: Abdur Rehman <abdur.rehman@toradex.com>
@embdur
vpu: Generic: Add metadata and documentation
470e9d4 
Signed-off-by: Abdur Rehman <abdur.rehman@toradex.com>
@andreriesco
Copy link
Collaborator

LGTM

@andreriesco andreriesco merged commit ea700c3 into toradex:bookworm-new Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leograba leograba leograba left review comments

@leonheldattoradex leonheldattoradex leonheldattoradex left review comments

@andreriesco andreriesco Awaiting requested review from andreriesco

@microhobby microhobby Awaiting requested review from microhobby

@charles2910 charles2910 Awaiting requested review from charles2910

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@embdur @leonheldattoradex @leograba @andreriesco