Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 2.0 to PDFVersion #179

Open
torakiki opened this issue Aug 9, 2015 · 0 comments
Open

Add 2.0 to PDFVersion #179

torakiki opened this issue Aug 9, 2015 · 0 comments
Labels
enhancement model
Milestone
2.0.0.M1

Comments

@torakiki
Copy link
Owner

torakiki commented Aug 9, 2015

This is apparently trivial but it has an impact since we have a single int version of the pdf version that is used as friendly name (i.e. 7 means 1.7, 6 means 1.6 etc) and we can't map version 2.0 that way. I think it doesn't make much sense to use that representation (maybe it's something coming from iText 2??) and we should probably change the friendly name with the two digit version (i.e 1.7, 2.0 ...). This will impact the sejda-console where version number is currently specified using the single digit.
@torakiki torakiki added this to the 2.0.0.M1 milestone Aug 9, 2015
torakiki added a commit that referenced this issue Jan 16, 2016
@torakiki
ref #179: moved to a two digits version parameter. From 5 to 1.5.
f5d42de 
This is a breaking change to accomodate PDF version 2.0
torakiki added a commit that referenced this issue Jan 17, 2016
@torakiki
ref #179: added a smooth transition between single digit to two digits
7c89f83 
pdf version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement model
Projects
None yet
Milestone
2.0.0.M1
Development

No branches or pull requests
1 participant
@torakiki