switch the names of the properties on a record proxy to avoid collisi… #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons with defined values. fixes #56
|
Awesome - you mind altering the store/type properties in the record-array model also (for consistency mostly, no need to write a failing test as the Array returned doesn't usually have properties like store/type anyway). I'll merge this in w/ those changes and get a bump to 4.2.0 this afternoon -sound good? |
|
Sounds good, will do |
|
Pushed up changes. Snagged the filtered array in there as well. |
|
I just bumped this to v4.2.0 / tagged it and did the npm publish :) let me know if you run into anything else during the big v4 upgrade you guys are doing! thanks for the quick /and complete work today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ons with defined values. fixes #56