added support for multiple wallboxes #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 30, 2024
Merged
|
Thanks for merging! I am curious to get some real users feedback :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the first feedback, I added multi-wallbox capability rightaway.
According to E3DC RSCP spec, up to 8 Wallboxes are supported.
If there's only one wallbox, WB entities are names "Wallbox ...", if there are more, they are numbered starting with 1.
WB name/key/index is kept in a central list of Dict, so more advanced naming conventions could be introduced easily.
As this can become a very long list of wallbox entities, ideally each wallbox would be a own device.
I explored this a little bit but i'm afraid this would be a bigger refactoring of this integration or something, which requires a deeper understanding of HA.
As i only have one wallbox at home, i could only verify, that the behaviour of that one is still correct, for the other wallboxes, i could just verify that namings, keys and calling python-e3dc works as intended but of course i could not verify if correct data is returned.
However I'd suggest to update the Beta in order to get feedback from e.g. @Thomansky to test the multi-wallbox-functions.