added accUpdate to nn.LookupTable #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any news on this? |
|
This PR changes nothing to the existing interface. It just allows for switching gradWeight/gradBias off so as to save memory. |
|
okay cool, why not use the .training = false that we use for the other modules |
|
Its not the same. train = false is for Modules having a different behaviour for training vs evaluation. This is for deleting the gradWeight/gradBias to half the memory footprint of the Module. |
koraykv
added a commit
that referenced
this pull request
Jul 17, 2014
added accUpdate to nn.LookupTable
|
Thanks! This is useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add method accUpdateOnly() to nn.LookupTable. This allows the LookupTable to function without the gradWeights tensor. This is useful when you want to save memory (especially for GPU) as this Module can use up a great proportion of your available memory. Added unit tests.