Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.1 rockspec #1

Closed
akfidjeland opened this issue Oct 9, 2013 · 3 comments
Closed

Add 1.1 rockspec #1

akfidjeland opened this issue Oct 9, 2013 · 3 comments

Comments

@akfidjeland
Copy link

The latest set of changes removes a number of functions, so some existing code may break. How about tagging 5f8c734 as 1.0 and adding a v1.1 rockspec pointing to HEAD? That way we can keep existing code working by just modifying our rockspecs.

@clementfarabet
Copy link
Member

Hey Andreas, sorry about the aggressive change. A lot of the functionalities were redundant with the "paths" package provided in Torch. I've created a new version 1.1-0, and now 1.0-0 is pointing 5f8c734. Is it working for you? I believe this restores the previous version:

torch-rocks install sys 1.0-0

@akfidjeland
Copy link
Author

No worries, I see the need for removing duplicate functionality. Downgrading like you suggest works a charm, thanks.

@clementfarabet
Copy link
Member

Great!

Eventually, this package should disappear. We should just keep the
essential functions. On my end I mostly only need the high-res timer, and
sys.execute(), which pipes its results to a string.

On Wed, Oct 9, 2013 at 6:57 PM, Andreas Fidjeland
notifications@github.comwrote:

No worries, I see the need for removing duplicate functionality.
Downgrading like you suggest works a charm, thanks.


Reply to this email directly or view it on GitHubhttps://github.com//issues/1#issuecomment-26016310
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants