Made sure strings won't break

torch2424 · Oct 9, 2020 · 4034096 · 4034096
1 parent 614e7f5
commit 4034096
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/asbind-instance/bind-function.js b/lib/asbind-instance/bind-function.js
@@ -226,7 +226,10 @@ export function bindExportFunction(asbindInstance, exportFunctionKey) {
       }
 
       if (supportedType) {
-        if (functionThis.unsafeReturnValue) {
+        if (
+          functionThis.unsafeReturnValue &&
+          supportedType.getUnsafeValueFromRef
+        ) {
           response = supportedType.getUnsafeValueFromRef(
             exports,
             exportFunctionResponse

diff --git a/test/test.js b/test/test.js
@@ -658,6 +658,12 @@ describe("asbind", () => {
       );
     });
 
+    it("should not break strings", () => {
+      asbindInstance.exports.helloWorld.unsafeReturnValue = true;
+      const response = asbindInstance.exports.helloWorld("asbind");
+      assert.equal(response, "Hello asbind!");
+    });
+
     // TypedArrays
     [
       "Int8Array",