Pin non-primitive function parameters #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torch2424
approved these changes
Jul 21, 2021
| @@ -71,14 +71,25 @@ export function bindExportFunction( | |||
| `Expected ${argumentConverterFunctions.length} arguments, got ${args.length}` | |||
| ); | |||
| } | |||
| const newArgs = args.map((v, i) => | |||
| argumentConverterFunctions[i]( | |||
| // The conversion function of the _next_ parameter could potentially | |||
There was a problem hiding this comment.
Ah! Thank you for the comment here! It's super helpful! 😄 🎉
| @@ -0,0 +1,8 @@ | |||
| exports.mangleCompilerParams = params => { | |||
There was a problem hiding this comment.
Thank you very much for the tests as well! 😄 🎉
|
@surma I can't seem to get Travis to be happy even though I did a whole new migration and things. 😭😭😭 Can you maybe sucking your local branch, closing this PR, and try opening a new PR and see if that works? 🤔 |
|
(Closing and re-opening to maybe make travis happy?) |
|
Finally found the travis issue: |
|
Found the issue 🙃 travis-ci/docs-travis-ci-com#733 (comment) |
|
Thanks for landing this @torch2424! Appreciate you taking care of that part! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85
cc @RehkitzDev